Mm2 1788 be - add a custom provider for auth extended emailpass #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-add-a-custom-provider-for-auth-extended-emailpass
|
🚅 Deployed to the mercur-pr-506 environment in [DEV & QA] mercur-internal
|
itariv
reviewed
Nov 21, 2025
| const providerIdentity = copy.provider_identities?.find( | ||
| (pi) => pi.provider === this.provider | ||
| )! | ||
| delete providerIdentity.provider_metadata?.password |
Collaborator
There was a problem hiding this comment.
Why we are deleting password?
Collaborator
Author
There was a problem hiding this comment.
probably to ensure that it's not returned, even though only the copy is returned not the original object.
this part wasn't modified from the original: https://github.com/medusajs/medusa/blob/beb91d88a2f224075e4fcf35a0ee9483b3124504/packages/modules/providers/auth-emailpass/src/services/emailpass.ts#L136
itariv
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new custom provider extending the default medusa emailpass provider with some more functionality like:
name and last_name verification, email matches for same email but with lowercase and optionally suffixed emails.
Also some more extensive errors when it comes to validation and registering on the same email.