[WIP] Fix page scroll to top after portfolio generation completes

[Copilot]

After portfolio analysis completes, the page scrolls to top due to Streamlit reruns, forcing users to manually scroll down to view results.

Changes

Added scroll-to-element behavior:

• HTML anchor (<div id="portfolio-section"></div>) at portfolio section
• Session state flag scroll_to_portfolio tracks when portfolio is first generated
• JavaScript injection scrolls smoothly to anchor on completion, then resets flag

Implementation:

# Set flag when portfolio generates
st.session_state.generated_portfolio = portfolio
st.session_state.scroll_to_portfolio = True

# On render, inject scroll behavior if flag is set
if st.session_state.scroll_to_portfolio:
    st.markdown(f"""
        <script>
        setTimeout(function() {{
            document.getElementById('portfolio-section')
                .scrollIntoView({{ behavior: 'smooth', block: 'start' }});
        }}, {SCROLL_TO_PORTFOLIO_DELAY_MS});
        </script>
    """, unsafe_allow_html=True)
    st.session_state.scroll_to_portfolio = False

Configuration:

• SCROLL_TO_PORTFOLIO_DELAY_MS = 100 - delay ensures Streamlit content renders before scroll
• Flag resets on conversation clear and provider change

Testing

Added tests/unit/test_scroll_to_portfolio.py verifying constant definition, session state initialization, and JavaScript implementation.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[BUG] Page Scrolls to Top After Portfolio and PAC Analysis Completion</issue_title>
<issue_description>## Description
When the portfolio analysis and PAC metrics extraction are completed, the page automatically scrolls to the top, forcing users to manually scroll down to view the newly generated portfolio recommendations and analysis results. This creates a poor user experience as users lose their position on the page.

Reproducibility information

Branch: develop
This issue occurs consistently at the end of the financial assessment flow, after all questions have been answered and the portfolio analysis has been generated.

Expected behavior

After the portfolio and PAC metrics analysis completes, the page should:

1. Either maintain the user's current scroll position
2. Or smoothly scroll to the relevant section showing the newly generated portfolio recommendations
3. Keep the user in context so they can immediately see the generated analysis without manual scrolling

Expected behavior: Minimal scroll movement or a smooth scroll to the analysis section, allowing users to immediately view their results.

Actual behavior

After portfolio analysis completion, the page scrolls all the way to the top (likely due to a st.rerun() call), and users must manually scroll down to see the generated portfolio, PAC metrics, and other analysis results. This interrupts the user flow and reduces usability.

Current behavior: Full page scroll to top, requiring significant manual scrolling to return to the analysis section.

Attachments

Steps to reproduce:

1. Start the financial assessment
2. Answer all 12 questions completely
3. Wait for the portfolio generation to complete
4. Observe the page jumping to the top of the page
5. Note that you must scroll down to see the generated portfolio results

Browser/Environment:

• Streamlit application
• Tested on: macOS, Chrome browser

Further content

• This issue likely occurs due to st.rerun() calls in app.py (lines around portfolio generation)
• Consider using Streamlit's scroll behavior management or avoiding st.rerun() if possible
• Alternative solutions:
  • Use st.session_state to preserve scroll position
  • Implement smooth scrolling to the analysis section using JavaScript injection
  • Use Streamlit's st.anchor() or similar anchor functionality to jump directly to results
  • Consider restructuring the layout to keep portfolio results in a more accessible location
• The issue is particularly problematic for users on mobile devices where scrolling is more cumbersome
• Test the fix across different screen sizes and devices
  </issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes [BUG] Page Scrolls to Top After Portfolio and PAC Analysis Completion #21

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.