Fix scroll behavior after portfolio analysis completion #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulation plus started to modifying app.py to have a smooth scroll (still to be finished)
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue where the page scrolls to the top after portfolio analysis completion by implementing JavaScript-based smooth scrolling to the bottom of the page. Additionally, it refactors the portfolio percentage validation from an error-throwing validator to an auto-normalization approach.
- Implements JavaScript scroll functionality to automatically scroll to bottom after portfolio completion
- Refactors portfolio percentage validation from strict validation to auto-normalization
- Moves chat input placement before the conversation completion check
Reviewed Changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/models/portfolio.py | Replaces strict percentage validation with auto-normalization logic; adds unused math import; includes commented-out old code and TODO comment |
| app.py | Adds _scroll_to_bottom() function using JavaScript injection; reorganizes chat input placement; adds scroll call after portfolio display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the application to address the issue of the page scrolling to the top after portfolio analysis completion. Implement a smooth scroll to the relevant section, enhancing user experience. Clean up the scroll function and ensure robust percentage calculations in the portfolio model.
Fixes #21