feat: add hamburger mobile navigation for responsive homepage (fixes #11)#112
Conversation
… 980px The homepage nav-links were hidden on screens narrower than 980px via display:none, but no mobile navigation was provided as a replacement. This left users with no way to access Product, Solutions, Marketplace, How it works, or Ledger Logs pages on mobile devices. Changes: - Add hamburger toggle button (3-line icon / X icon) that shows on screens under 980px - Add slide-in mobile nav panel with the same navigation links - Add semi-transparent backdrop overlay that closes nav on tap - Mobile nav links close the panel on click and navigate correctly - All new elements use existing CSS variables for consistent theming Verified on 375px, 430px, 768px, and 1440px viewports. Build passes with vite build (SSR + client). Fixes mergeos-bounties#11
EvidenceFiles: +83 lines (App.vue +16, styles.css +67) Checks: @TUPM96 This branch is based on fresh origin/master and includes all CI files. PR is clean from unrelated changes. |
QA Verification Report — PR #112PR: #112 1. GitHub Actions StatusNo CI checks configured on this PR (Checks tab shows 0). 2. Local Build & Test
3. Manual Code ReviewWhat the PR claims to doAdd hamburger toggle + slide-in mobile nav panel for viewports < 980px. What the PR actually changes (scope concerns)Intended changes (good):
Unrelated changes (scope creep):
AssessmentThe hamburger feature itself is well-implemented: clean CSS, proper z-index layering (overlay z-45, panel z-50), backdrop blur, and responsive breakpoint. However, the PR bundles multiple unrelated changes that revert or alter existing functionality — particularly the Bug Fix project type workflow and dashboard navigation logic. These changes are not mentioned in the PR description and go beyond the scope of issue #11. 4. Evidence StatusThe author provided a verification table with viewport test results (375px, 430px, 768px, 1440px). No screenshots or GIF were attached — evidence is incomplete per bounty rules (which require screenshots, video/GIF, or console logs). 5. RecommendationRequest changes. Reasons:
Suggested fix: Split the PR into (a) hamburger mobile nav only, and (b) separate PRs for the other changes with their own issues and justification. |
TUPM96
left a comment
There was a problem hiding this comment.
Reviewed diff and maintainer follow-up. Scope is now limited to the mobile homepage navigation fix, with no workflow/security-sensitive changes. Local npm test/build:local pass and GitHub PR checks are green.
|
MergeOS approved and merged this PR.
|
Fix: Homepage has no mobile navigation
On screens narrower than 980px,
.nav-linkswere hidden viadisplay: nonebut no mobile navigation was provided.Changes
App.vue — Added hamburger toggle button + slide-in mobile nav panel + backdrop overlay
styles.css — 67 lines of CSS for hamburger button, overlay, panel, and media query
Verification
Build:
npm run buildpasses.Fixes #11