feat(expenses): reusable AssetSelector with live fiat preview - #418
Merged
Conversation
Introduces a reusable neo-brutalist AssetSelector (issue mergepay#401): asset selection for XLM / stable / custom trustline tokens with a live fiat equivalent that updates as the crypto amount is typed, using the existing CoinGecko-backed useCurrencyRates hook and convertToFiat helper. Wires it into the add-expense dialog in place of the raw asset select. Closes mergepay#401
|
@codexhange Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
MergeKeeper review unavailable AI provider review response did not contain valid JSON No approval or merge action was taken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #401 — a controlled, keyboard-accessible asset selector with real-time conversion.
What's included
src/components/expenses/AssetSelector.tsx— controlled component (value/agentonChange) supporting XLM (native), the stable asset, and custom trustline tokens, in the neobrutalist style.useCurrencyRateshook andconvertToFiathelper (with precision handling on the Stellar grid).<label>,aria-props, andaria-livefor the conversion preview.<select>in the add-expense dialog.Closes #401