-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/4743_markdown_support_timeline_diagrams #4852
Open
jonnymuir
wants to merge
20
commits into
mermaid-js:develop
Choose a base branch
from
jonnymuir:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+274
−16
Open
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9279166
feat: Add markup support to timeline diagrams
jonnymuir 34272c2
Merge branch 'develop' of https://github.com/jonnymoo/mermaid into de…
jonnymuir b843df8
Merge branch 'develop' into develop
jonnymuir e96d0f6
chore: missing test for coverage
jonnymuir 770a650
Added image snapshot tests for timelines
jonnymuir 1bbc94a
Loosen the regex for <br> to allow spaces on drawnode
jonnymuir 86b61d1
Merge branch 'develop' into develop
jonnymuir 775ab1b
Update docs
2fad40b
Merge branch 'develop' into pr/jonnymoo/4852
sidharthv96 ee90db9
Merge branch 'develop' into develop
sidharthv96 469dff3
tidy: Clarify logic
jonnymuir 5a5d677
Merge branch 'develop' of https://github.com/jonnymoo/mermaid into de…
jonnymuir 2ce718b
feat: Add markup support to timeline diagrams
jonnymuir 0a19f9c
chore: missing test for coverage
jonnymuir da40147
Added image snapshot tests for timelines
jonnymuir 6ecb3cb
Loosen the regex for <br> to allow spaces on drawnode
jonnymuir 4f94e07
tidy: Clarify logic
jonnymuir f166232
Merge branch 'develop' of https://github.com/jonnymoo/mermaid into de…
jonnymuir 0d8d7f8
chore: clean up imports
jonnymuir 1f59bb4
Merge branch 'develop' into develop
jonnymuir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update docs
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing against it, but this is a bit out of the scope for the task. Let it be here, since you've already added it, but it's better to keep PR directly related to the issue, that would make tracking the issue down much easier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh - yeh - I agree. I'm not sure why it is here either? I haven't added it on purpose - has it come through on a merge or automatically somehow? More than happy for them to be removed - I don't know where the links have come from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is probably originates from the merge commit, yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a commit which didn't update the docs. Most probably this was added by the pre-commit hook.
You can ignore these. It will go away once you sync the latest develop.