Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Node with text renders by default as Markdown #6087

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
+72 −28
Open

fix: Node with text renders by default as Markdown #6087

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f27ca07
Adding back create label for the cases where you do not want markdown…
knsv Nov 27, 2024
c7880d7
Adding changeset
knsv Nov 27, 2024
468b6a5
Update cypress/integration/rendering/flowchart.spec.js
jgreywolf Dec 2, 2024
4693aa2
Merge branch 'develop' into 5824-diff-between-markdown-and-strings
jgreywolf Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding changeset
@knsv
knsv committed Nov 27, 2024
commit c7880d728132e9e4af7cf699953273ab75aa0175
5 changes: 5 additions & 0 deletions .changeset/gold-ducks-sort.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'mermaid': patch
---

fix: Proper separation between strings and markdown strings

Unchanged files with check annotations Beta

View file
packages/mermaid-example-diagram/src/types/index.d.ts
declare global {
interface Window {
mermaid: any; // 👈️ turn off type checking

Check warning on line 5 in packages/mermaid-example-diagram/src/types/index.d.ts

GitHub Actions / autofix 

Unexpected any. Specify a different type
}
}
View file
packages/mermaid-layout-elk/src/render.ts
}: InternalHelpers,
{ algorithm }: RenderOptions
) => {
const nodeDb: Record<string, any> = {};

Check warning on line 39 in packages/mermaid-layout-elk/src/render.ts

GitHub Actions / autofix 

Unexpected any. Specify a different type
const clusterDb: Record<string, any> = {};

Check warning on line 40 in packages/mermaid-layout-elk/src/render.ts

GitHub Actions / autofix 

Unexpected any. Specify a different type
const addVertex = async (
nodeEl: SVGGroup,
const drawNodes = async (
relX: number,
relY: number,
nodeArray: any[],

Check warning on line 115 in packages/mermaid-layout-elk/src/render.ts

GitHub Actions / autofix 

Unexpected any. Specify a different type
svg: any,

Check warning on line 116 in packages/mermaid-layout-elk/src/render.ts

GitHub Actions / autofix 

Unexpected any. Specify a different type
subgraphsEl: SVGGroup,
depth: number
) => {
await Promise.all(
nodeArray.map(async function (node: {
id: string | number;
x: any;

Check warning on line 123 in packages/mermaid-layout-elk/src/render.ts

GitHub Actions / autofix 

Unexpected any. Specify a different type
y: any;

Check warning on line 124 in packages/mermaid-layout-elk/src/render.ts

GitHub Actions / autofix 

Unexpected any. Specify a different type
width: number;
labels: { width: any }[];

Check warning on line 126 in packages/mermaid-layout-elk/src/render.ts

GitHub Actions / autofix 

Unexpected any. Specify a different type
height: number;
isGroup: any;

Check warning on line 128 in packages/mermaid-layout-elk/src/render.ts

GitHub Actions / autofix 

Unexpected any. Specify a different type
labelData: any;

Check warning on line 129 in packages/mermaid-layout-elk/src/render.ts

GitHub Actions / autofix 

Unexpected any. Specify a different type
offset: { posX: number; posY: number };
shape: any;
domId: { node: () => any; attr: (arg0: string, arg1: string) => void };