Skip to content

[Architecture/fix] Throw explicit error for invalid configuration causing overlapping nodes#6176

Closed
NicolasNewman wants to merge 9 commits into
mermaid-js:developfrom
NicolasNewman:6120/architecture-node-overlap
Closed

[Architecture/fix] Throw explicit error for invalid configuration causing overlapping nodes#6176
NicolasNewman wants to merge 9 commits into
mermaid-js:developfrom
NicolasNewman:6120/architecture-node-overlap

Conversation

@NicolasNewman
Copy link
Copy Markdown
Collaborator

@NicolasNewman NicolasNewman commented Jan 9, 2025

📑 Summary

To avoid user confusion, Architecture diagrams now explicitly throw an error if two services attempt to connect to the same side of another service.

Resolves #6120

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 09da4bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 9, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 09da4bf
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6797f5ed24a55f000897bf38
😎 Deploy Preview https://deploy-preview-6176--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jan 9, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6176
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6176
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6176
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6176

commit: 09da4bf

@argos-ci
Copy link
Copy Markdown

argos-ci Bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Awaiting the start of a new Argos build…

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 24, 2025

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.47%. Comparing base (e2de552) to head (09da4bf).
⚠️ Report is 2439 commits behind head on develop.

Files with missing lines Patch % Lines
...ermaid/src/diagrams/architecture/architectureDb.ts 0.00% 16 Missing ⚠️
...aid/src/diagrams/architecture/architectureTypes.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6176      +/-   ##
==========================================
- Coverage     4.47%   4.47%   -0.01%     
==========================================
  Files          384     385       +1     
  Lines        54179   54207      +28     
  Branches       623     598      -25     
==========================================
  Hits          2425    2425              
- Misses       51754   51782      +28     
Flag Coverage Δ
unit 4.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...aid/src/diagrams/architecture/architectureTypes.ts 0.00% <0.00%> (ø)
...ermaid/src/diagrams/architecture/architectureDb.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NicolasNewman
Copy link
Copy Markdown
Collaborator Author

Closing as a better solution is being worked on in #7707 and #7708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Architecture diagram: Nodes overlap in same group

2 participants