Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1233 set height of text on edge #6214

Draft
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

megantriplett
Copy link

📑 Summary

Brief description about the content of your PR.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: b3f273e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Enhancement New feature or request label Jan 22, 2025
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit b3f273e
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67a565e099d4eb000814b17c
😎 Deploy Preview https://deploy-preview-6214--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jan 22, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6214
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6214
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6214
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6214

commit: b3f273e

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 135 lines in your changes missing coverage. Please review.

Project coverage is 4.46%. Comparing base (8dd0e7a) to head (b3f273e).

Files with missing lines Patch % Lines
...aid/src/rendering-util/rendering-elements/edges.js 0.00% 130 Missing ⚠️
packages/mermaid/src/rendering-util/createText.ts 0.00% 4 Missing ⚠️
packages/mermaid/src/diagrams/common/common.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6214      +/-   ##
==========================================
- Coverage     4.47%   4.46%   -0.01%     
==========================================
  Files          385     384       -1     
  Lines        54191   54292     +101     
  Branches       598     623      +25     
==========================================
  Hits          2425    2425              
- Misses       51766   51867     +101     
Flag Coverage Δ
unit 4.46% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/common/common.ts 53.01% <0.00%> (ø)
packages/mermaid/src/rendering-util/createText.ts 0.00% <0.00%> (ø)
...aid/src/rendering-util/rendering-elements/edges.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants