feat: networkDiagram type (#1227)#7766
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 9ea4219 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7766 +/- ##
==========================================
- Coverage 3.26% 3.24% -0.03%
==========================================
Files 600 611 +11
Lines 60744 61567 +823
Branches 917 928 +11
==========================================
+ Hits 1986 1995 +9
- Misses 58758 59572 +814
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
aloisklink
left a comment
There was a problem hiding this comment.
Hi @aqys, thanks for your contribution!
Is there any reason why this should be a separate diagram and we can't just add icons for firewall/router/switch to architecture diagrams?
There seems to substantial overlap with architecture diagrams: https://mermaid.js.org/syntax/architecture.html Even your proposed syntax and layout algorithm are quite similar.
|
Hi @aloisklink. Thank you for the feedback, and you're right that there's overlap. The main differences are:
That said, I'm open to the alternative of extending the architecture |
Closes #1227
Adds a new
networkDiagramtype for network topologies.What
packages/parser/src/language/network/) with nodes,per-node metadata, subnets, and directional links (
---,-->,<--,<-->)packages/mermaid/src/diagrams/network/): db, parser,renderer (d3-force layout), styles, detector, types
defaultConfig.ts, .build/jsonSchema.ts
syntax/network.md),examples entry, theme integration (forest)
Screenshots
Tests