Skip to content

docs(wardley): fix component label offset order in "Complete Example"#7769

Open
kimulaco wants to merge 1 commit into
mermaid-js:developfrom
kimulaco:fix/7768
Open

docs(wardley): fix component label offset order in "Complete Example"#7769
kimulaco wants to merge 1 commit into
mermaid-js:developfrom
kimulaco:fix/7768

Conversation

@kimulaco
Copy link
Copy Markdown
Contributor

📑 Summary

Fix a syntax error in the "Complete Example" section of the Wardley Maps docs. The label [x, y] offset was placed after the source-strategy decorator (build), which the grammar does not accept.

Resolves #7768

📏 Design Decisions

The wardley.langium Component rule defines label=Label? decorator=Decorator?, meaning label must precede the decorator. The fix swaps the order in the one affected line.

- component "Web App" [0.75, 0.80] (build) label [-60, 10]
+ component "Web App" [0.75, 0.80] label [-60, 10] (build)

📋 Tasks

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 21, 2026

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 4f722b6
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/6a0f14bba89e51000811192a
😎 Deploy Preview https://deploy-preview-7769--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 21, 2026

⚠️ No Changeset found

Latest commit: 4f722b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the Type: Bug / Error Something isn't working or is incorrect label May 21, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 21, 2026

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/@mermaid-js/examples@7769

mermaid

npm i https://pkg.pr.new/mermaid@7769

@mermaid-js/layout-elk

npm i https://pkg.pr.new/@mermaid-js/layout-elk@7769

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/@mermaid-js/layout-tidy-tree@7769

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/@mermaid-js/mermaid-zenuml@7769

@mermaid-js/parser

npm i https://pkg.pr.new/@mermaid-js/parser@7769

@mermaid-js/tiny

npm i https://pkg.pr.new/@mermaid-js/tiny@7769

commit: 4f722b6

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.26%. Comparing base (46e8044) to head (4f722b6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #7769      +/-   ##
==========================================
- Coverage     3.26%   3.26%   -0.01%     
==========================================
  Files          599     600       +1     
  Lines        60839   60850      +11     
  Branches       917     917              
==========================================
  Hits          1986    1986              
- Misses       58853   58864      +11     
Flag Coverage Δ
unit 3.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug / Error Something isn't working or is incorrect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Wardley Maps "Complete Example" fails to render

1 participant