Skip to content

Refactor: Move buzzer sound handling to class members, tune sounds, #1883

Open
alco28 wants to merge 3 commits intomeshcore-dev:mainfrom
alco28:feature/buzzer-sound-refactor-clean
Open

Refactor: Move buzzer sound handling to class members, tune sounds, #1883
alco28 wants to merge 3 commits intomeshcore-dev:mainfrom
alco28:feature/buzzer-sound-refactor-clean

Conversation

@alco28
Copy link

@alco28 alco28 commented Feb 28, 2026

This PR introduces the following improvements:

  • Refactored buzzer sound handling: all RTTTL melodies are now class members (startup_song, shutdown_song, message_song, discovery_song, channel_song, ack_song) in the buzzer class for better maintainability and reuse.
  • Slightly tuned the channel and ack buzzer sounds for clearer and more consistent user feedback.
  • Added a PlatformIO build task to tasks.json for convenient building directly from within VS Code.
  • Replaced all hardcoded RTTTL strings in the codebase with these class members, allowing centralized management and easier future adjustments of buzzer sounds.

No changes to board configuration files are included in this PR. This refactor improves code clarity, maintainability, and user experience.

…ings with class member variables for better maintainability.
…ings with class member variables for better maintainability. Add tasks.json for PlatformIO build configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant