Peek & pop separately when pushing messages to BLE client#1902
Open
weebl2000 wants to merge 1 commit intomeshcore-dev:devfrom
Open
Peek & pop separately when pushing messages to BLE client#1902weebl2000 wants to merge 1 commit intomeshcore-dev:devfrom
weebl2000 wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
robekl
reviewed
Mar 3, 2026
| if ((out_len = getFromOfflineQueue(out_frame)) > 0) { | ||
| _serial->writeFrame(out_frame, out_len); | ||
| if ((out_len = peekOfflineQueue(out_frame)) > 0) { | ||
| if (_serial->writeFrame(out_frame, out_len) > 0) { |
There was a problem hiding this comment.
should a partial write (writeFrame(...) > 0 and less than out_len) be considered success, eg enough to pop the frame from the queue?
I've noticed very often that the first few messages can get lost after reconnecting with BLE. This should fix that.
weebl2000
force-pushed
the
no-fire-and-forget-ble-message-popping
branch
from
c520542 to
782118d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed very often that the first few messages can get lost after reconnecting with BLE. This should fix that.
Try for yourself by building here