Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change mitigates one-byte direct-hop collisions by preferring flood routing when a contact’s direct path is ambiguous.
It updates
BaseChatMeshso direct-path selection is ambiguity-aware and consistently applied across send/ACK/response/keep-alive paths.What Changed
BaseChatMesh.shouldUseDirectPath(...)and switched direct-send decisions to use it instead of only checkingOUT_PATH_UNKNOWN.direct_path_ambiguous[MAX_CONTACTS]) and cache update helpers.out_path_lenvalues when evaluating direct-path eligibility.Why This Is Needed
With one-byte hop prefixes, multiple contacts can share the same prefix. Treating any known out-path as safe for direct routing can select an ambiguous route and reduce delivery reliability. This change makes direct routing conditional on path uniqueness to avoid those cases.
Impact If Included
Impact If Not Included
Benefits
Drawbacks
MAX_CONTACTS.