fix(cli): parse tempradio args without mutable copy and document timeout cap#1910
Open
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Open
fix(cli): parse tempradio args without mutable copy and document timeout cap#1910robekl wants to merge 1 commit intomeshcore-dev:devfrom
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens
tempradioCLI parsing by removing mutable-copy tokenization and parsing arguments directly from the input command string.It also updates CLI docs to match the new timeout validation range.
What Changed
strcpy(tmp, &command[10])+parseTextParts(...)fortempradioparsing with a non-mutating parser that reads directly fromcommand + 10.timeout_minsmust be1-32767.Why
The previous
tempradiopath copied unbounded user input into a fixed-size internal buffer. This could overflow internal object memory for long CLI input.The new parser avoids copying entirely for this command path and validates structure explicitly.
Behavior Notes
tempradionow requires well-formed comma-separated input and rejects malformed trailing content.timeout_minsis now explicitly capped at32767minutes, matching implementation and avoiding unsafe large time conversions.Validation
CommonCLI::handleCommand.