Skip to content

upgrade statichcheck-action to v1.3.0#313

Open
pratikgitss wants to merge 2 commits into
meshery-extensions:masterfrom
pratikgitss:bug/pratikgitss/13041
Open

upgrade statichcheck-action to v1.3.0#313
pratikgitss wants to merge 2 commits into
meshery-extensions:masterfrom
pratikgitss:bug/pratikgitss/13041

Conversation

@pratikgitss

@pratikgitss pratikgitss commented Dec 29, 2024

Copy link
Copy Markdown

Description

This PR fixes meshery/meshery#13041, upgrading dominikh/staticcheck-action@v1 to dominikh/staticcheck-action@v1.3.0

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Pratik Wasekar <pratikwasekar13@gmail.com>
@pratikgitss pratikgitss changed the title upgrade statichcheck-action to v1.3.0: Added proper sign-off upgrade statichcheck-action to v1.3.0: Dec 29, 2024
@pratikgitss pratikgitss changed the title upgrade statichcheck-action to v1.3.0: upgrade statichcheck-action to v1.3.0 Dec 29, 2024
@pratikgitss

Copy link
Copy Markdown
Author

@devhindo can you review this!

@devhindo devhindo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devhindo

Copy link
Copy Markdown

yes, but in everywhere in the repo. there exist multiple setup-go actions

@pratikgitss

Copy link
Copy Markdown
Author

so i am required to change the setup-go actions wherever present in the repo, am i correct?

@pratikgitss pratikgitss reopened this Dec 29, 2024
@devhindo

Copy link
Copy Markdown

yes

Signed-off-by: Pratik Wasekar <pratikwasekar13@gmail.com>
@pratikgitss

Copy link
Copy Markdown
Author

I have made the changes as you said.

@lekaf974 lekaf974 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade statichcheck-action to v1.3.0 across all repos

3 participants