ci: migrate golangci-lint config to v2 format and enforce linting#346
Open
Devesanoff wants to merge 1 commit into
Open
ci: migrate golangci-lint config to v2 format and enforce linting#346Devesanoff wants to merge 1 commit into
Devesanoff wants to merge 1 commit into
Conversation
Signed-off-by: Devesanoff <esanovmadaminjon@gmail.com>
banana-three-join
requested changes
Apr 29, 2026
There was a problem hiding this comment.
workflow currently uses actions/checkout@v3 across all of it's use cases. they need to be updated to checkout@v6.
| steps: | ||
| - name: Check out code | ||
| uses: actions/checkout@v3 | ||
| - name: golangci-lint |
There was a problem hiding this comment.
go version being used for the linter needs to be setup
| name: Build check | ||
| runs-on: ubuntu-latest | ||
| # needs: [lint, error_check, static_check, vet, sec_check, tests] | ||
| needs: [lint] |
There was a problem hiding this comment.
keep comment but remove lint from comment
|
|
||
| run: | ||
| timeout: 5m | ||
| skip-dirs: |
There was a problem hiding this comment.
skip-dirs is deprecated. utilize exclude-dirs instead.
There was a problem hiding this comment.
Rules and comments shouldn't be discarded in order to migrate to the new golangci-lint version. The rules still hold even through the version change, they need to be rewritten instead of being just removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the
.golangci.ymlconfiguration to version 2, aligning it with the latestgolangci-lintstandards. It also updates the CI workflow inbuild-and-release.ymlto include a dedicatedlintjob, ensuring the build process is protected by code quality checks.Notes for Reviewers
.golangci.ymltoversion: 2.lintjob to the GitHub Actions workflow.buildjob to depend on thelintjob (needs: [lint]).DCO(Developer Certificate of Origin) is signed.staticchecksettings to allow lowercase error messages (standard for Meshery).Signed commits