[#692] Fix MeshSync test flake & Refactor Client usage #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tset Update Broker and MeshSync controllers and associated packages to use the controller-runtime client for resource health checks and endpoint retrieval. Signed-off-by: Amr-Shams <[email protected]>
Wrap the MeshSync update logic in an Eventually block to handle potential conflicts during reconciliation in test environments. Signed-off-by: Amr-Shams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
conditions during high-concurrency test runs.
This PR fixes #
Notes for Reviewers
this fix introduced the way to use the client local cache as the first layer (the watcher updates the local cache through events)
during the test we needed to hit the row api for k8s for the high freq(other wise i think the cache should be more safe) wq
Signed commits