-
Notifications
You must be signed in to change notification settings - Fork 637
Feat: create programs layout #2085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat: create programs layout #2085
Conversation
Signed-off-by: karan-palan <[email protected]>
Signed-off-by: karan-palan <[email protected]>
Signed-off-by: karan-palan <[email protected]>
Signed-off-by: karan-palan <[email protected]>
Signed-off-by: karan-palan <[email protected]>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@M-DEV-1 , kindly push your changes and describe the issues you faced that we talked about here (header is hardcoded, breaks layout etc.) |
Thanks @Karan-Palan, I'll push the changes soon. |
@Karan-Palan merge conflicts |
…te-programs-layout Signed-off-by: M-DEV-1 <[email protected]>
Signed-off-by: M-DEV-1 <[email protected]>
Signed-off-by: M-DEV-1 <[email protected]>
Signed-off-by: M-DEV-1 <[email protected]>
Signed-off-by: M-DEV-1 <[email protected]>
…cture Signed-off-by: M-DEV-1 <[email protected]>
Signed-off-by: M-DEV-1 <[email protected]>
Signed-off-by: M-DEV-1 <[email protected]>
Signed-off-by: M-DEV-1 <[email protected]>
Screencast.from.2025-03-26.03-48-08.webm@vishalvivekm layout for gsoc pages are completed, and render properly in both desktop and mobile view. |
Signed-off-by: M-DEV-1 <[email protected]>
Signed-off-by: M-DEV-1 <[email protected]>
Signed-off-by: M-DEV-1 <[email protected]>
size: "medium (~175 hour projects)" | ||
mentors: | ||
- name: "Ian Whitney" | ||
link: "https://layer5.io/community/members/ian-whitney" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
page doesn't exist yet, should i change this to github link?
link: "https://layer5.io/community/members/ian-whitney" | |
link: "https://github.com/ianrwhitney" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@M-DEV-1, yes, that would be good. I thought that @ianrwhitney had been invited to have a member profile. Is there an open PR on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the issue - layer5io/layer5#6047 and there's an open PR for it - layer5io/layer5#6346. If that's merged, we can link to the member profile
<ol>{{ page.community_what }}</ol> | ||
</ul> | ||
<ul> | ||
<ol><b>Is it Open Source?</b></ol> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This question seems silly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, this file is not in use anymore. I was supposed to delete it. I'll do that.
{{ page.description | markdownify }} | ||
|
||
{% if page.video_embed %} | ||
<div class="video-embed"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is a video of Lee explaining Layer5, it can be removed, @vishalvivekm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been removed completely, the embed is kept just in case someone wants to add a video in the future.
Signed-off-by: M-DEV-1 <[email protected]>
@Karan-Palan @M-DEV-1 as this is ready to be reviewed, Let's discuss this on websites meeting today. |
js/toc.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this and js/linkify.js
to assets/js
, if you would.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 done @vishalvivekm
Signed-off-by: M-DEV-1 <[email protected]>
…create-programs-layout
e5f444d
to
6327a93
Compare
Description
Re-opening PR #2057 as I had some issues with old fork.
This PR fixes #2054
Notes for Reviewers
Signed commits