Skip to content

Feat: create programs layout #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

Karan-Palan
Copy link

Description

Re-opening PR #2057 as I had some issues with old fork.

This PR fixes #2054

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 6327a93
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/67f3c80d2409f90008060da3
😎 Deploy Preview https://deploy-preview-2085--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Karan-Palan
Copy link
Author

@M-DEV-1 , kindly push your changes and describe the issues you faced that we talked about here (header is hardcoded, breaks layout etc.)

@M-DEV-1
Copy link
Contributor

M-DEV-1 commented Mar 24, 2025

Thanks @Karan-Palan, I'll push the changes soon.

@vishalvivekm
Copy link
Contributor

@Karan-Palan merge conflicts

@M-DEV-1
Copy link
Contributor

M-DEV-1 commented Mar 25, 2025

Screencast.from.2025-03-26.03-48-08.webm

@vishalvivekm layout for gsoc pages are completed, and render properly in both desktop and mobile view.

@Karan-Palan Karan-Palan marked this pull request as ready for review March 26, 2025 05:19
size: "medium (~175 hour projects)"
mentors:
- name: "Ian Whitney"
link: "https://layer5.io/community/members/ian-whitney"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

page doesn't exist yet, should i change this to github link?

Suggested change
link: "https://layer5.io/community/members/ian-whitney"
link: "https://github.com/ianrwhitney"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@M-DEV-1, yes, that would be good. I thought that @ianrwhitney had been invited to have a member profile. Is there an open PR on this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the issue - layer5io/layer5#6047 and there's an open PR for it - layer5io/layer5#6346. If that's merged, we can link to the member profile

<ol>{{ page.community_what }}</ol>
</ul>
<ul>
<ol><b>Is it Open Source?</b></ol>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This question seems silly.

Copy link
Contributor

@M-DEV-1 M-DEV-1 Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, this file is not in use anymore. I was supposed to delete it. I'll do that.

{{ page.description | markdownify }}

{% if page.video_embed %}
<div class="video-embed">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a video of Lee explaining Layer5, it can be removed, @vishalvivekm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been removed completely, the embed is kept just in case someone wants to add a video in the future.

@leecalcote leecalcote requested a review from vishalvivekm March 26, 2025 15:37
@vishalvivekm
Copy link
Contributor

@Karan-Palan @M-DEV-1 as this is ready to be reviewed, Let's discuss this on websites meeting today.
Adding in the agenda items: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit?pli=1&tab=t.0

js/toc.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this and js/linkify.js to assets/js, if you would.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 done @vishalvivekm

@M-DEV-1 M-DEV-1 force-pushed the feat/create-programs-layout branch 2 times, most recently from e5f444d to 6327a93 Compare April 7, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Website] enhance program pages for better readability and reusability
4 participants