Skip to content

add: Shape Builder to Extensions page #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

M-DEV-1
Copy link
Contributor

@M-DEV-1 M-DEV-1 commented Apr 23, 2025

Description

added Shape Builder to Meshery Extensions page

Notes for Reviewers
image
image
image

Signed commits

  • Yes, I signed my commits.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @M-DEV-1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request adds a new entry to the Meshery Extensions page for the Shape Builder tool. The Shape Builder is an interactive tool that allows users to visually create and customize component shapes for use in their designs. The new entry includes metadata such as the tool's name, type, compatibility, a brief description, and links to the tool and its documentation.

Highlights

  • New Extension: Adds a new extension entry for the Shape Builder tool to the Meshery Extensions page.
  • Metadata: Includes metadata for the Shape Builder tool, such as its name, type, compatibility, and links to the tool and its documentation.

Changelog

Click here to see the changelog
  • collections/_extensions/meshery-shape-builder.md
    • Added a new markdown file for the Shape Builder extension.
    • Defined the layout as a single-page extension.
    • Specified the name as 'Shape Builder'.
    • Set the kind to 'extension'.
    • Provided the userName as 'Meshery Authors'.
    • Included a userAvatarURL.
    • Set the type to 'Configuration'.
    • Indicated compatibility with 'meshery' and 'kanvas'.
    • Assigned an extensionId.
    • Linked the logo, whiteImage, and colorImage.
    • Added a description of the Shape Builder tool in extensionInfo.
    • Included information about creating and exporting custom shapes in extensionCaveats.
    • Provided the URL to the Shape Builder tool.
    • Linked to the documentation in docsURL.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A shape is born,
From code, a new design,
Meshery extends.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

netlify bot commented Apr 23, 2025

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 4ba1e3c
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6817a7c5ebd22100081fa2a5
😎 Deploy Preview https://deploy-preview-2147--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds a new extension, Shape Builder, to the Meshery Extensions page. The addition includes metadata such as the extension's name, type, compatibility, and links to its website and documentation. The overall structure and content seem appropriate for integrating the Shape Builder into the Meshery ecosystem.

Merge Readiness

The pull request appears to be well-structured and ready for merging. The addition of the Shape Builder extension enhances the Meshery ecosystem by providing users with a tool to visually create and customize component shapes. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

@M-DEV-1
Copy link
Contributor Author

M-DEV-1 commented Apr 23, 2025

image

The description for the Helm Plugin for Kanvas Snapshot is too long, and exceeds the maximum length for rendering in the card.

@M-DEV-1
Copy link
Contributor Author

M-DEV-1 commented Apr 23, 2025

image

@vishalvivekm
Copy link
Contributor

@M-DEV-1
Let's discuss this during the website call today at 5:30 PM IST

Added as an agenda item to the meeting minutes

@leecalcote
Copy link
Member

@Aditi4275, would you like to offer review on this PR?

@leecalcote leecalcote closed this Apr 29, 2025
@leecalcote leecalcote reopened this Apr 29, 2025
@Aditi4275
Copy link

Hi @leecalcote, I appreciate the mention! I'll review the PR soon and provide my feedback.

@Aditi4275
Copy link

@leecalcote LGTM, everything is working as intended.

@M-DEV-1 A separate issue and PR can be raised for Helm plugin for Kanvas Snapshot.

name: Shape Builder
kind: extension
userName: Meshery Authors
userAvatarURL: https://png.pngtree.com/png-vector/20191104/ourmid/pngtree-businessman-avatar-cartoon-style-png-image_1953664.jpg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this used for?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hotlinking like this often results in 404s. Please reference a locally saved asset

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @codered-lgtm, i had taken reference from the other extensions files which used the same link. i'll look for the locally saved asset and use it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Shape Builder is a custom polygon builder used for personalized component representation in Kanvas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants