Skip to content

fix: buttons overflow on home page #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: buttons overflow on home page #2157

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e26722
fix: buttons overflow on home page
M-DEV-1 May 3, 2025
80593ec
rm redundant style
codered-lgtm May 4, 2025
2c4f9b8
Merge branch 'master' into M-DEV-1/fix-home-buttons
codered-lgtm May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions _sass/forms.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@
}
}

@media (max-width: 480px) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the .button-para always has its width set to fit-content, I am not sure how setting the width to 100% helps here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the button was breaking in mobile view, by forcing the element to take maximum-width we can prevent the breaking onto newline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it works, but the issue is difficult to reproduce on desktops, so there might be a better approach to solving this too

.button-para {
width: 100%;
}
}

.button-para .link{
display: flex;
border: none;
Expand Down
Loading