Fix: Cloud Native Patterns Logo on home page, remove unused section #2158
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @M-DEV-1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses issue # by fixing the Cloud Native Patterns logo on the home page and removing an unused section. The logo has been updated to a new SVG, and the unused section has been commented out in _includes/features.html. The changes improve the visual appearance of the home page and remove unnecessary code.
Highlights
- Logo Update: The Cloud Native Patterns logo on the home page has been updated to a new SVG file (
/assets/images/logos/service-mesh-pattern.svg). The old logo and associated styling have been removed. - Unused Section Removal: An unused section in
_includes/features.htmlhas been commented out to clean up the codebase.
Changelog
- _includes/features.html
- Updated the Cloud Native Patterns logo to a new SVG.
- Removed the old logo and associated styling.
- Commented out an unused section to clean up the codebase.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A logo's changed,
Old code now estranged,
The page is cleaner,
A welcome demeanour,
Design's refreshed range.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Code Review
This PR addresses the issue of the Cloud Native Patterns logo on the home page and removes an unused section. The changes seem straightforward and improve the visual presentation of the website. The use of before and after screenshots in the PR description is helpful for understanding the impact of the changes.
Summary of Findings
- Unused Section Removal: The removal of the commented-out section is a good cleanup, reducing unnecessary code in the template.
- Logo Update: The update of the Cloud Native Patterns logo enhances the visual appeal and potentially improves brand consistency.
- Image Optimization: Consider optimizing the new logo image for web use to reduce file size and improve page load times.
Merge Readiness
The pull request appears to be in good shape for merging. The changes are relatively small and focused, addressing the stated issue effectively. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging. There are no critical or high severity issues that would block merging.
_includes/features.html
Outdated
| alt="Cloud native design patterns" style="height: 4rem;" loading="lazy" /> | ||
| <span> | ||
| </div> | ||
| <img src="/assets/images/logos/service-mesh-pattern.svg" style="max-width:20%;position:relative;float:left;margin-right:20px;margin-bottom: 10px;" loading="lazy" alt="Cloud native design patterns"/> |
There was a problem hiding this comment.
Thank you @M-DEV-1
Let's ensure:
- move inline style to specific sheet, as much as possible, for reusability
- keep
data-logo-for-lightanddata-logo-for-dark, attributes, they can have the same value, if theme friendly versions of an asset is not available currently
There was a problem hiding this comment.
thanks @codered-lgtm, i'll keep the data-logo attributes. i'll try to move the inline styles to the respective sheet.
|
@M-DEV-1 Add it as an agenda item to the meeting minutes, if you would :) |
|
@M-DEV-1 did we incorporate the feedback offered above ^^ |
|
@devanmolx, would you like to offer review on this PR? |
|
Looks good! Just noticed the image has changed — if that’s intentional, all good. Just confirming. Before: |
Description
This PR fixes #
Ref:
https://mesheryio.slack.com/archives/C015QJKUMPU/p1746280089583189
Before:
After:
Before:
After:
Notes for Reviewers
Signed commits