-
Notifications
You must be signed in to change notification settings - Fork 742
Update Meshery Catalog to Golang 1.25 #2506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: arhmm7 <[email protected]>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @arhmm7, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request upgrades the Go language version used across the Meshery Catalog. It specifically targets the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the project to use Go 1.25. The go.mod file is updated from version 1.24.5 to 1.25. As mentioned in the description, the GitHub Actions workflows are also updated from Go 1.23 to 1.25. This change not only brings the project up-to-date with a newer Go version but also improves consistency between the module's declared Go version and the CI environment. The change in the provided diff is correct and I have no further suggestions.
Signed-off-by: arhmm7 <[email protected]>
|
@arhmm7 |
Signed-off-by: Arham <[email protected]>
This PR fixes #2472
add-catalog.yml: 1.23 → 1.25
error-code-updater.yml: 1.23 → 1.25