-
Notifications
You must be signed in to change notification settings - Fork 742
Fix: Blog pagination and category routing #2516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: yugalkaushik <[email protected]>
Signed-off-by: yugalkaushik <[email protected]>
Signed-off-by: yugalkaushik <[email protected]>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @yugalkaushik, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical routing issues within the blog section of the website. It involves migrating the underlying pagination system to a new Jekyll plugin and updating various configuration and template files. These changes ensure that blog post pagination and category page links function correctly, resolving incorrect redirects and 404 errors previously experienced by users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully fixes issues with blog pagination and category routing by migrating from octopress-paginate to the more modern jekyll-paginate-v2 plugin. The configuration and template changes correctly update the URL structures. My review includes a couple of suggestions to improve the implementation further by using plugin-provided variables for generating pagination links, which enhances maintainability, and by ensuring all internal links are portable, adhering to the project's conventions.
|
hello @yugalkaushik |
|
@yugalkaushik Thank you for your contribution! Let's discuss this during the website call today at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
Description
Blog
Previously, pagination from https://meshery.io/blog redirected users to https://meshery.io/page/2 , which is incorrect. This has now been fixed to correctly route pagination to https://meshery.io/blog/page/2
Before


After

Category
Previously, selecting a category on the https://meshery.io/blog/category page resulted in a 404 error for each category page.


Signed commits