-
Notifications
You must be signed in to change notification settings - Fork 742
Fix for desktop and Mobile: SVG Error for CNCF page #2524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Bhumika Garg <[email protected]>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @Bhumikagarggg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves an issue where SVG images on the CNCF page were not displaying correctly across different devices. The changes involve updating image source paths to ensure they load reliably and adjusting the associated CSS to improve the layout and responsiveness of these images, thereby enhancing the user experience and accessibility of the page. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully resolves the SVG rendering issue on the CNCF page by correcting image asset paths and refining the CSS for better responsiveness on desktop and mobile. The changes are effective and well-scoped. I've provided a few suggestions to enhance the maintainability and consistency of the new HTML and CSS code, such as using CSS for spacing instead of <br> tags, removing a redundant CSS property, and using consistent units for padding values.
|
hello @saurabhraghuvanshii |
Signed-off-by: Bhumika Garg <[email protected]>
|
@saurabhraghuvanshii Thanks for the review! |
|
@Bhumikagarggg |
Signed-off-by: Bhumika Garg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These images are outdated. For example, Meshery is shown with 343 stars and 69 contributors, which is no longer accurate. Please use updated images with the latest stats.
// @Bhumikagarggg
Description
This PR fixes #2507 by correcting broken asset paths and refining the related CSS to ensure images render correctly.
The updates are intentionally minimal and focus only on resolving the reported issues.
Notes for Reviewers
Screenshot

Signed commits