Fix: community redirects and missing dev redirect plugin #2527
Conversation
Signed-off-by: yugalkaushik <[email protected]>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @yugalkaushik, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the Community page was not consistently accessible in production when a trailing slash was used in the URL. By implementing a redirect, the page now behaves uniformly across different environments, improving user experience and resolving a known bug. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly resolves an issue where the community page was inaccessible with a trailing slash. By adding a redirect_from entry in collections/_pages/community.html, requests to /community/ will now properly redirect to the canonical /community URL. This is a standard and effective approach for Jekyll sites. The implementation is sound and I have no further suggestions.
…nity link Signed-off-by: yugalkaushik <[email protected]>
|
@kishore08-07 In the development configuration file, the redirect plugin was missing, so I added it as well, as its absence was causing redirect errors during development. |
yugalkaushik
changed the title
Bhumikagarggg
left a comment
Bhumikagarggg
left a comment
There was a problem hiding this comment.
I don’t think these three changes are necessary. @yugalkaushik, we’re aiming to keep this fix very minimal. This issue can be resolved with a much smaller change.
|
@Bhumikagarggg among the three can you point out which one you found unnecessary and not minimal. |
There was a problem hiding this comment.
@yugalkaushik Just remove '/' from this link https://meshery.io/community/. it will solve your issue.
There was a problem hiding this comment.
This is the minimal fix but it won't solve the actual issue, hardcoding the link makes it irrelevant for development and preview. This is just one instance where trailing stash for community is causing 404 but there are multiple instances of community/ in the repo.
|
@yugalkaushik Thank you for your contribution! Let's discuss this during the website call tomorrow at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
3 participants
Description
This PR fixes #2523
Notes for Reviewers
Signed commits