-
Notifications
You must be signed in to change notification settings - Fork 742
fix: remove duplicate responsive action buttons across program pages #2537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: remove duplicate responsive action buttons across program pages #2537
Conversation
…2023, MLH, GSOD pages Signed-off-by: Bhumika Garg <[email protected]>
Summary of ChangesHello @Bhumikagarggg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the user interface by addressing inconsistencies in action buttons across several program pages. The changes streamline the display of 'Join Slack' and 'Participate' buttons, ensuring that only a single, responsive call-to-action is present on each page, thereby improving user experience and maintaining a cohesive design. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully removes duplicate action buttons from several program pages, simplifying the code and improving responsiveness. However, I've identified a few issues that should be addressed. In one file, a button's text now mismatches its link destination. In another, removing a button has left behind an empty <ul> tag, resulting in invalid HTML. There's also a minor typo (a leading space) in a URL. I've detailed these points in the comments.
I am having trouble creating individual review comments. Click here to see my feedback.
collections/_programs/gsod_2020.html (146)
While the button text is now correctly "Join Slack", the link it's wrapped in still points to /community#discussion-forums (on the line above). This is misleading for users. The href attribute of the <a> tag should be updated to https://slack.meshery.io.
collections/_programs/lfx.html (51-52)
By removing this button, the parent <ul> tag on line 50 becomes empty. This <ul> tag should also be removed to avoid leaving an empty list and creating invalid HTML (<ul></div>).
collections/_programs/lfx.html (530)
The href attribute in the parent <a> tag on the line above has a leading space (" https://..."). This should be removed for correctness.
Signed-off-by: Bhumika Garg <[email protected]>
… for join slack button Signed-off-by: Bhumika Garg <[email protected]>
Description
This PR fixes #2535 by removing duplicate Join Slack/Participate buttons on the LFX 2025, LFX 2023, MLH, and GSOD pages.
Notes for Reviewers
Screenshot
Signed commits