-
Notifications
You must be signed in to change notification settings - Fork 742
feat: Add Prettier formatting workflow #2538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @Sourya07, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a robust code formatting standard by integrating Prettier into the development workflow. The primary goal is to maintain a uniform code style, which enhances readability and simplifies collaboration. This change streamlines the contribution process by providing clear mechanisms for style adherence and automated validation. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Prettier to enforce a consistent code style across the repository, which is a great step for maintainability. The changes primarily consist of formatting adjustments applied by Prettier. I've reviewed the new configuration and the resulting code changes. My feedback includes a suggestion to improve the Prettier configuration for better consistency and a minor correction in one of the data files. Overall, this is a valuable addition to the project's tooling.
| "singleQuote": false, | ||
| "tabWidth": 2, | ||
| "trailingComma": "es5", | ||
| "useTabs": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better consistency across the repository, I recommend using spaces instead of tabs for indentation. While useTabs: true is set, Prettier will still use spaces for some file types like YAML, leading to a mixed indentation style. Using spaces everywhere is a more common convention and avoids rendering issues across different editors.
"useTabs": false
| date: "2025-06-19" | ||
| video: https://www.youtube.com/watch?v=K2gmdIlGXNo | ||
| embeded_video: https://www.youtube.com/embed/K2gmdIlGXNo | ||
| embeded_video: https://www.youtube.com/embed/K2gmdIlGXNo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9c1da42 to
6587205
Compare
Signed-off-by: Sourya07 <[email protected]>
Signed-off-by: Sourya07 <[email protected]>
6587205 to
c9355bd
Compare
|
@saurabhraghuvanshii can you please take a look here |
Description
This PR introduces automated code formatting using Prettier to ensure consistent code style across the repository.
This PR fixes #2534
Have two command ->
npm run lintnpm run formatHow it works
prettier --check .npm run formatlocally to fix formattingTesting
npm run lintpasses locallyNotes for Reviewers
Signed commits