Skip to content

Changed title bar color to black for issue #1704 and #1633. #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

todd2982
Copy link
Contributor

Updated title bar color as requested in light mode. Original white on green was difficult to read.

Before:
1704-before
After:
1704-after

@todd2982
Copy link
Contributor Author

Fixes issue #1704

@shortwavesurfer2009
Copy link

I don't know how apps do it, but it should also change the notification icons such as the time, Wi-Fi, cellular signal, etc.

@shortwavesurfer2009
Copy link

Does this also fix the buttons when you're in a chat such as copy, delete and select all?

@todd2982 todd2982 marked this pull request as draft March 24, 2025 20:38
@todd2982
Copy link
Contributor Author

Converting this to draft. @shortwavesurfer2009 brought up some things that still need to be changed.

@shortwavesurfer2009
Copy link

Looks like the node names will need changing too
Screenshot_20250324-181427_Meshtastic_1

@todd2982
Copy link
Contributor Author

Does this also fix the buttons when you're in a chat such as copy, delete and select all?

This is corrected.

@todd2982
Copy link
Contributor Author

Looks like the node names will need changing too Screenshot_20250324-181427_Meshtastic_1

This is corrected.

@todd2982
Copy link
Contributor Author

I don't know how apps do it, but it should also change the notification icons such as the time, Wi-Fi, cellular signal, etc.

I'm still researching this

@todd2982
Copy link
Contributor Author

I don't know how apps do it, but it should also change the notification icons such as the time, Wi-Fi, cellular signal, etc.

The option I found to fix this is by adding <item name="android:windowLightStatusBar">true</item> (Boolean testing needed), but I run into an issue with the minimum API target version. This theme change requires version 23, but we have a target configured for 21. Thoughts?

I don't want to make changes to the target versions without a serious conversation first. Also, since I'm so new at this there may be a better way. I've reached the end of my google-fu on this one for the moment.

@todd2982
Copy link
Contributor Author

Should include issue #1633 in this effort.

@todd2982 todd2982 changed the title Changed title bar color to black for issue #1704. Changed title bar color to black for issue #1704 and #1633. Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants