Skip to content

fix: Remove imePadding modifier to internal scaffold box #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jsoberg
Copy link
Contributor

@jsoberg jsoberg commented Apr 19, 2025

fixes #1603
fixes #1767

BaseScaffold is applying imePadding() to an internal Box on all screen-level Composables. This is evidently unnecessary with our setup and applies double keyboard padding for older devices.

On my Samsung A10e, Android 9:

Before After
BEFORE.mp4
AFTER.mp4

Also tested on my Samsung S23 Ultra to verify this change didn't affect devices that didn't have this issue.

@jsoberg jsoberg requested a review from jamesarich April 19, 2025 14:24
@jamesarich
Copy link
Contributor

@jsoberg have we tried how this works with edge to edge on 35? We'll eventually want to bump our target sdk up and we'll need to audit for edge to edge stuff since we're on material 2.

@jamesarich jamesarich merged commit edb514a into meshtastic:master Apr 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants