feat: Enhance mPWRD-os WiFi provisioning success state and UI components#5225
Merged
Conversation
Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Android/sessions/22899363-5662-41ba-8afc-1b30c6511925 Co-authored-by: jamesarich <2199651+jamesarich@users.noreply.github.com>
Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Android/sessions/22899363-5662-41ba-8afc-1b30c6511925 Co-authored-by: jamesarich <2199651+jamesarich@users.noreply.github.com>
Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Android/sessions/22899363-5662-41ba-8afc-1b30c6511925 Co-authored-by: jamesarich <2199651+jamesarich@users.noreply.github.com>
- Refactor ProvisionInfoCard into ProvisionInfoItem using Material3 ListItem for better alignment - Update ProvisionSuccessContent spacing and padding to improve visual hierarchy - Replace standard Button with FilledTonalButton for the SSH action - Add a Light/Dark mode Compose preview for the provisioning success state
Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Android/sessions/22899363-5662-41ba-8afc-1b30c6511925 Co-authored-by: jamesarich <2199651+jamesarich@users.noreply.github.com>
Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Android/sessions/22899363-5662-41ba-8afc-1b30c6511925 Co-authored-by: jamesarich <2199651+jamesarich@users.noreply.github.com>
Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Android/sessions/22899363-5662-41ba-8afc-1b30c6511925 Co-authored-by: jamesarich <2199651+jamesarich@users.noreply.github.com>
- Refactor ProvisionInfoCard into ProvisionInfoItem using Material3 ListItem for better alignment - Update ProvisionSuccessContent spacing and padding to improve visual hierarchy - Replace standard Button with FilledTonalButton for the SSH action - Add a Light/Dark mode Compose preview for the provisioning success state
jamesarich
force-pushed
the
feat/polish-nymea-mpwr-os-provisioning
branch
from
April 23, 2026 01:11
9298f93 to
b338323
Compare
…ioning' into feat/polish-nymea-mpwr-os-provisioning
jamesarich
enabled auto-merge
April 23, 2026 01:16
Copilot AI
added a commit
that referenced
this pull request
Apr 24, 2026
…nts (#5225) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the Wi-Fi provisioning feature by adding support for displaying the device's IP address after a successful connection and enriching the user experience with more detailed connection information. The changes span protocol updates, UI state management, and new UI strings for improved feedback to the user.
Wi-Fi Provisioning Protocol and Data Model Enhancements:
CMD_GET_CONNECTION) to request current connection details, including the device's IP address, and a short timeout constant for this optional metadata lookup (CONNECTION_INFO_TIMEOUT). [1] [2]NymeaConnectionInfo, which holds details such as SSID, BSSID, signal strength, protection status, and IP address. TheNymeaResponsemodel now optionally includes this connection info payload. [1] [2]ProvisionResult.Success) to carry the IP address if available.Business Logic and State Management:
NymeaWifiServiceto extract and return the IP address after a successful connection, using either the immediate response or a best-effort follow-up query. [1] [2] [3] [4] [5]WifiProvisionViewModelandWifiProvisionUiStateto store and propagate the IP address to the UI layer, resetting it appropriately during new provisioning attempts. [1] [2] [3]User Interface Improvements:
ipAddressproperty in various connection states. [1] [2] [3] [4] [5] [6] [7] [8]These changes collectively provide a more informative and user-friendly Wi-Fi provisioning experience, making it easier for users to complete device setup and connect via SSH.