Skip to content

fix(ui): align Cancel and Send enabled state#5284

Merged
jamesarich merged 2 commits into
meshtastic:mainfrom
elagin:bugfix/channel-footer-action-state-5282
Apr 29, 2026
Merged

fix(ui): align Cancel and Send enabled state#5284
jamesarich merged 2 commits into
meshtastic:mainfrom
elagin:bugfix/channel-footer-action-state-5282

Conversation

@elagin

@elagin elagin commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Fixes #5282

This change fixes inconsistent footer action behavior in Channel Config, where Send could appear active without actionable changes and Cancel did not follow the same enabled-state logic.

What changed

  • Updated shared PreferenceFooter so both Cancel and Send respect the same enabled state.
  • Kept Channel Config as the source of truth for action availability (enabled && isEditing).
  • Ensured visual state now matches actual button behavior.

Why

  • Prevents misleading UI state.
  • Makes unsaved-changes workflow clearer.
  • Reduces accidental confusion before leaving the screen.

Validation

  • ./gradlew :core:ui:spotlessApply
  • Manual check on Channels screen:
    • no edits -> footer actions are disabled
    • after edits -> footer actions are enabled

@CLAassistant

CLAassistant commented Apr 29, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot added the bugfix PR tag label Apr 29, 2026
@jamesarich
jamesarich enabled auto-merge April 29, 2026 15:02
@jamesarich
jamesarich added this pull request to the merge queue Apr 29, 2026
Merged via the queue into meshtastic:main with commit 575b7e5 Apr 29, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Channel Config "Cancel" and "Send" buttons have inconsistent enabled state vs unsaved changes

3 participants