Skip to content

fix: ensure snackbar respects safe drawing padding over host modifiers #5290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesarich merged 1 commit into from
Apr 29, 2026
Merged

fix: ensure snackbar respects safe drawing padding over host modifiers #5290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/MeshtasticSnackbarHost.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package org.meshtastic.core.ui.component

import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.safeDrawingPadding
import androidx.compose.material3.SnackbarHost
import androidx.compose.material3.SnackbarHostState
import androidx.compose.material3.SnackbarResult
Expand Down Expand Up @@ -61,7 +62,7 @@ fun MeshtasticSnackbarProvider(
content()
SnackbarHost(
hostState = snackbarHostState,
modifier = Modifier.align(Alignment.BottomCenter).then(hostModifier),
modifier = Modifier.align(Alignment.BottomCenter).safeDrawingPadding().then(hostModifier),
)
}
}
3 changes: 2 additions & 1 deletion core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/TransportIcon.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package org.meshtastic.core.ui.component
import androidx.compose.material3.Icon
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import org.jetbrains.compose.resources.stringResource
import org.meshtastic.core.resources.Res
import org.meshtastic.core.resources.internal
Expand Down Expand Up @@ -46,5 +47,5 @@ fun TransportIcon(transport: Int, viaMqtt: Boolean, modifier: Modifier = Modifie
MeshtasticIcons.Device to stringResource(Res.string.internal)
else -> return
}
Icon(icon, contentDescription = description, modifier = modifier)
Icon(icon, contentDescription = description, modifier = modifier, tint = Color.White)
}
6 changes: 2 additions & 4 deletions ...messaging/src/commonMain/kotlin/org/meshtastic/feature/messaging/component/MessageItem.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,10 +305,7 @@ fun MessageItem(
imageVector = MeshtasticIcons.HopCount,
contentDescription = null,
modifier = Modifier.size(14.dp),
tint =
contentColor.copy(
alpha = if (contrastLevel == ContrastLevel.HIGH) 1f else 0.7f,
),
tint = Color.White,
)
Text(
text =
Expand All @@ -318,6 +315,7 @@ fun MessageItem(
"?"
},
style = metadataStyle,
color = Color.White,
)
}
}
Expand Down