refactor(map): migrate custom overlays to the maps-utils 5.0 data layer

[jamesarich]

Follow-up to #6301. That bump pulled android-maps-utils 5.0.0, which deprecated the entire com.google.maps.android.data KML/GeoJSON stack ("Use the new platform-agnostic data layer and renderer instead"). The catch: in 5.0.0 the deprecated classes are no longer the battle-tested 4.x implementations — they are thin bridges over the new pipeline, and the bridges break this feature at runtime. This PR moves the google-flavor custom map overlays (Map Layers) directly onto the new public pipeline, which both clears the deprecation and fixes the regressions the bridges would ship.

🐛 Bug Fixes (regressions in the 5.0.0 legacy bridges, avoided by migrating)

• GeoJSON/KML point features rendered invisible: the bridges map them to PointStyle(color = 0), which the renderer turns into marker alpha 0.
• Per-feature MultiPolygon styles silently dropped at render time — Meshtastic Site Planner coverage contours would lose their dBm colors and draw as default black outlines.
• Layer visibility toggling leaked MultiGeometry objects: MapViewRenderer.removeFeature keys rendered map objects by internal per-geometry copies in an IdentityHashMap, so removal no-ops and re-showing duplicates the geometry.

🛠️ Refactoring & Architecture

• MapLayerOverlay now parses via the new GeoJsonParser / KmlParser / KmzParser (zip magic sniffed — LayerType.KML covers both .kml and .kmz) and maps into the immutable DataLayer model via toLayer().
• applySimpleStyleSpec is reimplemented as a pass over the model features, preserving everything the upstream mapper misses: the legacy color fallback, rgb()/rgba() colors, the 0.35 default fill opacity that lets stacked contour bands read as a gradient, and PolygonStyle for MultiPolygon (upstream styles any multi-geometry as a line).
• Rendering goes through a single-use MapViewRenderer per show, torn down with clear() — the only teardown that reliably removes MultiGeometry objects — re-wiring KMZ archive images via cacheImageData on each show.
• Zero @Deprecated maps-utils usages remain in the map code.

Behavior preserved: KML/KMZ/GeoJSON custom layers, per-feature simplestyle colors for Site Planner coverage exports, layer visibility toggling, refresh re-parse, points keep the default marker.

The three bridge/renderer bugs above are candidates for upstream reports against googlemaps/android-maps-utils.

Testing Performed

• ./gradlew spotlessApply spotlessCheck detekt assembleDebug test allTests — green.
• :androidApp:compileGoogleDebugKotlin — no deprecation warnings remain in map code.
• Draft until a device pass: loading a Site Planner coverage GeoJSON (per-band colors + opacity), a KMZ with icon images, and visibility toggle/refresh of each layer type.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Enhanced map-layer support for KML, KMZ, and GeoJSON, with smoother activation/deactivation of layers.
  • Updated styling for rendered map features, including improved handling of fill, stroke, transparency, and line widths.
• Improvements
  • More robust color parsing (hex, named colors, and rgb/rgba) to produce consistent visual results and safer fallbacks when styles can’t be interpreted.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7b168f35-18fc-4dad-86b8-4c28be6f0b02

📥 Commits

Reviewing files that changed from the base of the PR and between c80d0eb and 310f11f.

📒 Files selected for processing (1)

• androidApp/src/google/kotlin/org/meshtastic/app/map/MapView.kt

🚧 Files skipped from review as they are similar to previous changes (1)

• androidApp/src/google/kotlin/org/meshtastic/app/map/MapView.kt

---

📝 Walkthrough

Walkthrough

MapView.kt replaces Google maps-utils layer objects with a DataLayer and MapViewRenderer pipeline. It adds KMZ detection, unified GeoJSON/KML/KMZ parsing, simplestyle CSS color handling, renderer lifecycle management, and safe visibility toggling.

Changes

Map rendering pipeline

Layer / File(s)	Summary
DataLayer parsing and renderer lifecycle androidApp/src/google/kotlin/org/meshtastic/app/map/MapView.kt	GeoJSON, KML, and KMZ inputs are converted to DataLayer objects, rendered with MapViewRenderer, and shown or hidden through managed renderer lifecycle methods.
Simplestyle styling and color parsing androidApp/src/google/kotlin/org/meshtastic/app/map/MapView.kt	Features receive polygon and line styles from simplestyle properties, including CSS colors, opacity, and stroke width.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant MapLayerOverlay
  participant parseMapLayer
  participant MapViewRenderer
  MapLayerOverlay->>parseMapLayer: parse GeoJSON, KML, or KMZ
  parseMapLayer->>MapViewRenderer: provide DataLayer
  MapViewRenderer->>MapLayerOverlay: render or clear map layer

Loading

Possibly related PRs

• meshtastic/Meshtastic-Android#6301: Modifies the same map-layer handling and simplestyle behavior in MapView.kt.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly captures the main change: migrating custom map overlays to the maps-utils 5.0 data layer.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@androidApp/src/google/kotlin/org/meshtastic/app/map/MapView.kt`:
- Around line 1432-1448: Update Feature.applySimpleStyleSpec() to parse the
stroke-opacity property and apply it to the resolved stroke color before
rebuilding styles. Use the alpha-adjusted stroke color for both
PolygonStyle.strokeColor and LineStyle.color, while preserving existing
fill-opacity and default-color behavior.
- Around line 1316-1324: Move the parseMapLayer call out of the MapEffect
execution context so KML/KMZ/GeoJSON parsing runs on the injected IO dispatcher.
Prefer exposing this through MapLayersManager or MapViewModel; otherwise wrap
only the inputStream.use { parseMapLayer(...) } step with the IO dispatcher,
while preserving the existing null and RenderedMapLayer handling.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b7586055-bc2d-448b-b7f3-385de00b0902

📥 Commits

Reviewing files that changed from the base of the PR and between a0484e7 and c80d0eb.

📒 Files selected for processing (1)

• androidApp/src/google/kotlin/org/meshtastic/app/map/MapView.kt

[jamesarich]

The three upstream bugs this migration routes around are now filed with fix PRs against googlemaps/android-maps-utils:

• MultiGeometry removeFeature no-op (toggle leak/duplication): removeFeature() silently fails for MultiGeometry features (objects stranded on map, duplicated on re-add) googlemaps/android-maps-utils#1722 → PR fix: remove MultiGeometry features from the map in removeFeature googlemaps/android-maps-utils#1725
• Invisible bridge point markers (alpha 0): Point markers rendered invisible (alpha 0) through the legacy GeoJsonLayer/KmlLayer bridges googlemaps/android-maps-utils#1723 → PR fix: render legacy bridge point markers visible googlemaps/android-maps-utils#1726
• MultiPolygon styled as line (fill dropped): GeoJsonMapper applies LineStyle to MultiPolygon features, dropping simplestyle fill googlemaps/android-maps-utils#1724 → PR fix: apply polygon styling to GeoJSON MultiPolygon features googlemaps/android-maps-utils#1727

If/when those land, the single-use-renderer workaround and part of the local simplestyle pass here can be slimmed down — tracked for a future bump.

🤖 Generated with Claude Code