Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tab bar always background visible #1118

Merged
merged 2 commits into from
Mar 1, 2025
Merged

Make tab bar always background visible #1118

merged 2 commits into from
Mar 1, 2025

Conversation

RCGV1
Copy link
Member

@RCGV1 RCGV1 commented Mar 1, 2025

What changed?

The tab bar background is now always visible.

Why did it change?

Sometimes, the tab bar background would automatically go clear and ruin the UI.

How is this tested?

I tested it on my iPhone.

Screenshots/Videos (when applicable)

IMG_3237

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have made corresponding changes to the documentation.
  • I have tested the change to ensure that it works as intended.

@garthvh garthvh changed the base branch from main to 2.5.20 March 1, 2025 15:44
@garthvh
Copy link
Member

garthvh commented Mar 1, 2025

Probably can't hurt to make it explicit, but this is what the default is already I believe, not sure it will correct the underlying swiftui bug when dealing with large scrollviews.

@garthvh garthvh merged commit 52add6e into 2.5.20 Mar 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants