Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Environment Metrics to support latest Telemetry protobufs + chart scale improvements #1129

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jake-b
Copy link
Contributor

@jake-b jake-b commented Mar 12, 2025

What changed?

  • Updated protobufs to most recent versions. (Includes new telemetry like "Soil Moisture" and "Soil Temperature"
  • Added all telemetry fields to the database
  • Exposed these new telemetry fields in the chart.
  • Better Y-axis scaling for the Environment Metrics chart (Temperature now has a 50-degree range, and Humidity 0-100%) The API for MetricsChartSeries was extended to provide a minumumYAxisSpan and initialYAxisRange.
  • Compact widgets for some of these new metrics -- also split out the compact widgets into their own source code files.

Some of this enhancement was split out of the larger pull request #1037
This would close #1106

Why did it change?

  • Chart scaling: The pull request forces the chart to a 0-100 scale when humidity is added, and keeps the temperature scale to be a 50-degree spread. If the data requires larger scales, these ranges will be expanded as necessary.
  • Keep the viewable metrics up to date with what's available in the protobufs

How is this tested?

Tested on my local device against nodes that provide temperature and humidity data, and a few others out on the mesh that have similar sensors.
Also tested in MacCatalyst

I do not have nodes available with the proper hardware to test some of these telemetry fields (such as the luxes, soil measurements, and rainfall) so a wider beta would be warranted.

Screenshots/Videos

image
image

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have made corresponding changes to the documentation.
  • I have tested the change to ensure that it works as intended.

@jake-b jake-b changed the title EnvironmentMetrics chart scale improvements Update Environment Metrics to support latest Telemetry protobufs + chart scale improvements Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 [Feature Request]: Rain sensor in Environment Metrics Log
1 participant