fix: align EU and beacon frequency slots#2093
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
garthvh
left a comment
There was a problem hiding this comment.
Verified locally before merging (CI doesn't run tests):
- EU_866 now matches the firmware's Lite plan exactly — the values here are the ones worked out in #2091 from
RDEF(EU_866, 865.6f, 867.6f, ..., PROFILE_LITE)(spacing 0.4, padding 0.0375; LiteFast slot 1 → 865.700 MHz). - Beacon-side
slotForChannelNamenow resolves through the region default slot, closing the ham-band Add-vs-Switch gap from #2092 — matching-preset beacons on default-slot regions now correctly offer Add instead of a needless reboot. - Ran
LoRaChannelCalculatorTests,BeaconAddVsSwitchTests, andModemPresetFrequencySlotTestson the branch: 28 tests, all green — no regression to the existing slot math or beacon decisions.
Fast turnaround on both follow-ups — thanks!
Summary
Root cause
EU_866 retained obsolete frequency bounds with no Lite-profile spacing or padding. The beacon join comparison used the hash-only slot helper even after the connected-radio side became default-slot-aware, producing a needless Switch recommendation for matching ham meshes.
Validation
xcodebuild test -project Meshtastic.xcodeproj -scheme Meshtastic -destination 'platform=iOS Simulator,id=5669CB03-8FA2-4A97-BE04-A8566204116D' -only-testing:MeshtasticTests/LoRaChannelCalculatorTests -only-testing:MeshtasticTests/BeaconAddVsSwitchTestsFixes #2091
Fixes #2092
Summary by CodeRabbit
Bug Fixes
Tests