Skip to content

feat(messages): move find-in-conversation to a searchable field#2099

Merged
garthvh merged 1 commit into
mainfrom
feat/message-search-searchable
Jul 16, 2026
Merged

feat(messages): move find-in-conversation to a searchable field#2099
garthvh merged 1 commit into
mainfrom
feat/message-search-searchable

Conversation

@garthvh

@garthvh garthvh commented Jul 16, 2026

Copy link
Copy Markdown
Member

What

Replaces the custom magnifying-glass toolbar button for message search with a standard SwiftUI .searchable field, pinned in the navigation bar drawer of channel and direct-message conversations.

Why

.searchable is the platform-standard, discoverable entry point for search — no learning the custom icon, consistent with the rest of iOS, and it frees up the trailing toolbar slot. This builds directly on the find-in-conversation feature added in #2079.

Behavior

The find-in-page navigation is unchanged — only the entry point moved:

  • Type in the Find in conversation field below the title to search the conversation.
  • A results bar appears while a query is active, showing your position (e.g. 2 of 7) with up/down chevrons to step through matches, wrapping at the ends.
  • The current match is highlighted and scrolled into view, lazy-loading older messages as needed.
  • Matching stays case- and accent-insensitive over the entire conversation history.
  • Cancelling or clearing the field dismisses the results and returns to the conversation.

Notes

  • Applies to both ChannelMessageList and UserMessageList.
  • MessageSearchBar is now purely the results/navigation bar; the text field is owned by .searchable.
  • User docs updated (docs/user/messages.md).

Replace the custom magnifying-glass toolbar button with a standard
.searchable field in the navigation bar drawer. The find-in-page
navigation (live match count, prev/next chevrons, highlight + scroll,
lazy-loading older messages) is preserved via the results bar, which
now appears whenever the query is non-empty. Applies to both channel
and direct-message conversations.
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

An error occurred during the review process. Please try again later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@garthvh
garthvh merged commit 8a93640 into main Jul 16, 2026
3 of 4 checks passed
@garthvh
garthvh deleted the feat/message-search-searchable branch July 16, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant