feat(messages): move find-in-conversation to a searchable field#2099
Merged
Conversation
Replace the custom magnifying-glass toolbar button with a standard .searchable field in the navigation bar drawer. The find-in-page navigation (live match count, prev/next chevrons, highlight + scroll, lazy-loading older messages) is preserved via the results bar, which now appears whenever the query is non-empty. Applies to both channel and direct-message conversations.
Contributor
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the custom magnifying-glass toolbar button for message search with a standard SwiftUI
.searchablefield, pinned in the navigation bar drawer of channel and direct-message conversations.Why
.searchableis the platform-standard, discoverable entry point for search — no learning the custom icon, consistent with the rest of iOS, and it frees up the trailing toolbar slot. This builds directly on the find-in-conversation feature added in #2079.Behavior
The find-in-page navigation is unchanged — only the entry point moved:
Notes
ChannelMessageListandUserMessageList.MessageSearchBaris now purely the results/navigation bar; the text field is owned by.searchable.docs/user/messages.md).