fix: recover firmware releases when API proxy stalls#2100
Merged
garthvh merged 1 commit intoJul 17, 2026
Conversation
Contributor
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shipped firmware refresh path only requests https://api.meshtastic.org/github/firmware/list with a 5-second timeout. Its error is discarded by the startup task, and an error path leaves the firmware-loading state set to true. A first install therefore has no release catalog and stays on the updating state.
Live check on 2026-07-16:
This isolates the failure to the firmware-list proxy route rather than a general iOS/network outage.
Changes
Validation
The local pre-commit SwiftLint hook could not load sourcekitd in this shell; the Xcode simulator build's lint phase and focused tests completed successfully.