Skip to content

fix(canned-messages): stop writing deprecated allow_input_source (#2022) #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garthvh merged 1 commit into from
Jul 22, 2026
+4 −7
Merged

fix(canned-messages): stop writing deprecated allow_input_source (#2022) #2111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions Meshtastic/Views/Settings/Config/Module/CannedMessagesConfig.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,13 +188,10 @@ struct CannedMessagesConfig: View {
cmc.sendBell = sendBell
cmc.rotary1Enabled = rotary1Enabled
cmc.updown1Enabled = updown1Enabled
if rotary1Enabled {
cmc.allowInputSource = "rotEnc1"
} else if updown1Enabled {
cmc.allowInputSource = "upDown1"
} else {
cmc.allowInputSource = "_any"
}
// allow_input_source is deprecated with no successor — the input
// source is governed by the rotary1Enabled / updown1Enabled flags
// above. Intentionally not written; inbound values from older
// firmware are ignored (never persisted). (#2022)
cmc.inputbrokerPinA = UInt32(inputbrokerPinA)
cmc.inputbrokerPinB = UInt32(inputbrokerPinB)
cmc.inputbrokerPinPress = UInt32(inputbrokerPinPress)
Expand Down
Loading