feat(driver): display flush observer and opt-in remote input injection - #394
feat(driver): display flush observer and opt-in remote input injection#394jamesarich wants to merge 6 commits into
Conversation
DisplayDriver gains a static flush observer invoked from the LGFX flush callback before the in-place panel byte-swap, so observers receive native little-endian RGB565 dirty rects (LVGL thread; copy and return), plus a thread-safe requestFullRefresh drained in task_handler so a newly attached observer can synchronize the full frame. Both flush variants stay in sync. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lv_scr_act covers only the active screen; clock and notification overlays live on the top and system layers, so a full-frame sync for a flush observer must repaint those too. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
InputDriver gains injectTouch/injectKey statics callable from any thread: events land in lock-free SPSC rings drained by two always-present virtual LVGL devices created in the (previously empty) base init — a pointer whose read callback holds PRESSED for a requested duration (taps and synthesized long presses) and a keypad attached to the default group, which init now guarantees exists even on boards with no physical input so injected keys can navigate widgets. Mirrors the flush-observer pattern on the output side. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Two fixes for remote control. First: a slept panel swallowed injected input as a wake event, which is every event when nobody is physically at the device — inject* now raises a wake request drained on the UI thread (force wakeup when powersaving, otherwise reset the inactivity timer), distinct from toggleDisplay which would sleep an awake screen. Second: add a virtual encoder device, because LVGL moves focus between widgets on encoder rotation while keypad UP/DOWN go to the already-focused widget — so arrow keys silently did nothing while typed characters worked. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
The failure is in generating This diff is five C++ files ( What it looks like instead: I have not proven it by reproducing locally, so treat that as a strong hypothesis rather than a finding. If it holds, it will redden every PR until Note #393, opened the same day, shows no |
Creating the default input group unconditionally would enrol every focusable widget on touch-only boards that have no focus concept, so injection is now opt-in: a host calls enableInjection() before init(), and init() is otherwise inert as before. The flush observer becomes atomic with a documented detach-quiesce contract, its comment records that the tightly-packed pixel guarantee is PARTIAL-render-mode only and that LGFXDriver is the only driver honouring it, the injector contract narrows to single-producer (the rings are SPSC), and encoder steps clamp instead of truncating through int8. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
61cfbf7 to
6870270
Compare
|
Correcting my own comment above: the timing evidence I gave for the I said the last green What still stands: this diff is five C++ files under I have re-triggered CI to get a second datapoint. Treat the cause as unknown until that comes back, not as diagnosed. |
1 participant
Adds the two seams MUI needs so a host can mirror the panel and drive it remotely. Both are inert unless a host opts in — no default build changes behaviour.
This is the missing piece of the screen-mirroring stack: firmware currently consumes it through a
symlink://override inplatformio.ini, because no released device-ui carries the flush observer. Until this lands and a pin bumps, the whole MUI/colour path in meshtastic/firmware#11681 compiles out (HAS_MUI_MIRRORis 0) and only the 1bpp mono path works.What this adds
A display flush observer (
DisplayDriver::flushObserver, an atomic). Called on every LVGL flush before panel byte-swapping, so the observer sees the dirty area(x, y, w, h)and pixels as native little-endian RGB565 with rows tightly packed. Null by default; loaded with acquire semantics on the flush path.A cross-thread full-refresh request. A host streaming the screen needs to force a complete repaint from another thread.
fullRefreshRequestedis honoured on the LVGL thread intask_handler, and invalidates the active screen pluslv_layer_top()andlv_layer_sys()— overlay content (clock, notifications) lives on those layers, so a full sync has to repaint them too or the client sees a stale overlay.A wake request. Injected input must wake a slept panel and still act. Without this the first remote event is swallowed as a wake — which is every event, since remote control is exactly the case where nobody is physically at the device.
Opt-in remote input injection. A host calls
InputDriver::enableInjection()beforeinit()to add three LVGL virtual input devices — pointer, keypad, and encoder — fed from a 16-entry single-producer/single-consumer ring.injectTouch()supports a hold duration so long-press works;injectEncoder()maps rotation onto MUI's trackball semantics. Nothing is registered unlessenableInjection()was called.Scope and safety
injectionEnabledis false, so neither path is reachable without a host explicitly wiring it.<atomic>is the only added include.FromRadioand honouring a remote arm would stream the screen to whatever local client happens to be attached.Feature stack
Five repos, and the release order runs top to bottom. Nothing below can ship until the piece above it lands.
DisplayFrame/DisplayPalette/DisplayInfo+ the two admin verbscapture_displaytoolingdevice-ui#394 is the current blocker: without the flush observer the MUI/colour path compiles out of every committed firmware configuration, leaving only the 1bpp mono path.
Testing
Exercised on a LILYGO T-Deck via meshtastic/firmware#11681 with a local
symlink://override — live mirror plus D-pad, keyboard and touch control from Meshtastic-Android. Draft until reviewers weigh in on the seam shape; the firmware side is the only consumer today.