Skip to content

fix(devcontainer): install platformio as the vscode user #11264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
b-anantha wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −2
Open

fix(devcontainer): install platformio as the vscode user #11264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
libinput-dev \
&& apt-get clean && rm -rf /var/lib/apt/lists/*

RUN pipx install platformio

COPY 99-platformio-udev.rules /etc/udev/rules.d/99-platformio-udev.rules

USER vscode
Expand Down
2 changes: 2 additions & 0 deletions .devcontainer/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@
git submodule update --init

pip install --no-cache-dir setuptools

pipx install platformio
pipx install esptool
Comment on lines +7 to 8

@coderabbitai coderabbitai Bot Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Do not mask PlatformIO installation failures.

If pipx install platformio fails, the script continues to pipx install esptool; when that succeeds, postCreateCommand returns success even though pio is missing. Make the script fail fast so container creation cannot silently complete without PlatformIO.

Proposed fix 
 #!/usr/bin/env sh
+set -e

 git submodule update --init

Alternatively, explicitly chain the installation commands with &&.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.devcontainer/setup.sh around lines 7 - 8, Update the installation commands
in the setup script so a failure from pipx install platformio immediately
terminates the script and prevents the esptool step from masking it; enable
fail-fast behavior or explicitly chain the commands with &&.