Skip to content

Conversation

@StaticRocket
Copy link

@StaticRocket StaticRocket commented Jan 15, 2026

Operator precedence dictates that the addition will occur before the left shift unless we persuade the compiler to do otherwise.

Fixes: 45c1b46 ("Move native to spi_host to indicate spidev for LovyanGFX")

See the following unpacking logic for more information:
https://github.com/meshtastic/framework-portduino/blob/master/cores/portduino/linux/LinuxHardwareSPI.cpp#L84-L91

Operator precedence dictates that the addition will occur before the
left shift unless we persuade the compiler to do otherwise.

Fixes: 45c1b46 ("Move native to spi_host to indicate spidev for LovyanGFX")
Signed-off-by: Randolph Sapp <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Jan 15, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ thebentern
❌ StaticRocket
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Contributor

@StaticRocket, Welcome to Meshtastic!

Thanks for opening your first pull request. We really appreciate it.

We discuss work as a team in discord, please join us in the #firmware channel.
There's a big backlog of patches at the moment. If you have time,
please help us with some code review and testing of other PRs!

Welcome to the team 😄

@thebentern thebentern added the bugfix Pull request that fixes bugs label Jan 15, 2026
@jp-bennett
Copy link
Collaborator

jp-bennett commented Jan 15, 2026

Looks like this addresses #9315
Edit: on second look, appears to be a different issue

@StaticRocket
Copy link
Author

Not quite. It's a different bug I noticed while playing with that one.

@StaticRocket
Copy link
Author

Please hold on merging this if that CLA is still in effect. TI owns my commits both in and outside of the office so I need them to agree to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes bugs first-contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants