-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(PortduinoGlue): spi_dev_int packing #9319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Operator precedence dictates that the addition will occur before the left shift unless we persuade the compiler to do otherwise. Fixes: 45c1b46 ("Move native to spi_host to indicate spidev for LovyanGFX") Signed-off-by: Randolph Sapp <[email protected]>
|
|
|
|
@StaticRocket, Welcome to Meshtastic!Thanks for opening your first pull request. We really appreciate it. We discuss work as a team in discord, please join us in the #firmware channel. Welcome to the team 😄 |
|
Looks like this addresses #9315 |
|
Not quite. It's a different bug I noticed while playing with that one. |
|
Please hold on merging this if that CLA is still in effect. TI owns my commits both in and outside of the office so I need them to agree to it. |
Operator precedence dictates that the addition will occur before the left shift unless we persuade the compiler to do otherwise.
Fixes: 45c1b46 ("Move native to spi_host to indicate spidev for LovyanGFX")
See the following unpacking logic for more information:
https://github.com/meshtastic/framework-portduino/blob/master/cores/portduino/linux/LinuxHardwareSPI.cpp#L84-L91