Skip to content

Remove upstreamed protobuf packages - #77

Merged
vidplace7 merged 1 commit into
mainfrom
upstream-protobufs
Jun 30, 2026
Merged

Remove upstreamed protobuf packages#77
vidplace7 merged 1 commit into
mainfrom
upstream-protobufs

Conversation

@vidplace7

@vidplace7 vidplace7 commented Jun 30, 2026

Copy link
Copy Markdown
Member

These packages have been upstreamed in https://github.com/openwrt/packages and can be removed here.

Summary by CodeRabbit

  • Chores
    • Removed package build definitions for protobuf, protobuf-lite, and Python protobuf support.
    • Package metadata, build configuration, and install steps for these components are no longer included.
    • This reduces the set of bundled dependency packages available in the build.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ab114257-3d61-4e31-86d7-a5159cc84b75

📥 Commits

Reviewing files that changed from the base of the PR and between e6899b3 and 639dade.

📒 Files selected for processing (2)
  • depends/protobuf/Makefile
  • depends/python-protobuf/Makefile
💤 Files with no reviewable changes (2)
  • depends/python-protobuf/Makefile
  • depends/protobuf/Makefile

📝 Walkthrough

Walkthrough

Removes two OpenWrt package Makefiles: depends/protobuf/Makefile (122 lines) and depends/python-protobuf/Makefile (39 lines), eliminating all build, install, and packaging definitions for protobuf, protobuf-lite, and python3-protobuf.

Changes

Cohort / File(s) Summary
Removed package definitions
depends/protobuf/Makefile, depends/python-protobuf/Makefile
Both files deleted entirely, removing OpenWrt build/install rules for protobuf, protobuf-lite, and python3-protobuf.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 Snip snip snip, the Makefile's gone,
No more protobuf to carry on.
The rabbit swept the depends clean,
Two files removed — the shelf is lean.
Hop along, there's less to glean! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing protobuf-related packages that were upstreamed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@vidplace7
vidplace7 merged commit d5d8449 into main Jun 30, 2026
11 checks passed
@vidplace7
vidplace7 deleted the upstream-protobufs branch June 30, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant