Skip to content

Revert "Add python-charset-normalizer" - #86

Merged
vidplace7 merged 1 commit into
mainfrom
revert-85-python-charset-normalizer-v3.5.1
Aug 31, 2026
Merged

Revert "Add python-charset-normalizer"#86
vidplace7 merged 1 commit into
mainfrom
revert-85-python-charset-normalizer-v3.5.1

Conversation

@vidplace7

@vidplace7 vidplace7 commented Aug 31, 2026

Copy link
Copy Markdown
Member

Reverts #85

Already merged upstream

Summary by CodeRabbit

  • Chores
    • Removed the python3-charset-normalizer package and its source package from the build configuration.
    • Removed the associated host-build support and package metadata.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e9ab5122-830f-473f-a860-599671f1e404

📥 Commits

Reviewing files that changed from the base of the PR and between cc25b70 and 58d571d.

📒 Files selected for processing (1)
  • depends/python-charset-normalizer/Makefile
💤 Files with no reviewable changes (1)
  • depends/python-charset-normalizer/Makefile

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The python-charset-normalizer OpenWrt package Makefile was deleted. This removed its metadata, package definitions, build targets, and host build target.

Changes

Cohort / File(s) Summary
Package removal
depends/python-charset-normalizer/Makefile
Removes the python3-charset-normalizer and python3-charset-normalizer-src package definitions, build calls, metadata, and host build configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 58d57

This localized change removes the package definition without introducing an actionable merge-blocking risk; the PR is merge-ready after normal checks and review.

Poem

A rabbit found a package gone
Its Makefile slipped away at dawn
Metadata left the burrow too
Build targets vanished from view
The open path is clean and bright

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states that the pull request reverts the addition of python-charset-normalizer, which matches the deletion and the stated objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vidplace7
vidplace7 merged commit 61367ed into main Aug 31, 2026
11 checks passed
@vidplace7
vidplace7 deleted the revert-85-python-charset-normalizer-v3.5.1 branch August 31, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant