feat: add atomic channel profile protocol - #1013
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing this draft: the event-only firmware path should reuse existing channel QR add/replace semantics rather than introduce a new generic channel-profile protocol. The active work is limited to event firmware isolating its own channel and LoRa files so standard firmware naturally resumes the existing profile. |
Summary
AdminMessage.ChannelProfilerequest with explicitREPLACEandADDintentDeviceMetadataand persist the applied profile ID/digest withChannelFileConstraints
APPLY_MODE_UNSPECIFIEDis invalid; UI defaults to Replace but must send it explicitlyVerification
buf format --diff --exit-codebuf lintbuf breaking --against .git#branch=masterThis is a dependency draft for firmware#11109 and the on-device event profile restore work in meshtastic/firmware#11110. Related issue: #1012.