Skip to content

feat: add atomic channel profile protocol - #1013

Closed
RCGV1 wants to merge 1 commit into
meshtastic:masterfrom
RCGV1:codex/event-channel-profile-contract
Closed

feat: add atomic channel profile protocol#1013
RCGV1 wants to merge 1 commit into
meshtastic:masterfrom
RCGV1:codex/event-channel-profile-contract

Conversation

@RCGV1

@RCGV1 RCGV1 commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

  • add a versioned, channels-only AdminMessage.ChannelProfile request with explicit REPLACE and ADD intent
  • add a PSK-free completion/status response, including explicit reboot state
  • advertise capability through DeviceMetadata and persist the applied profile ID/digest with ChannelFile
  • add a status query so clients can verify an apply after reconnect

Constraints

  • no LoRa field exists in the profile payload
  • APPLY_MODE_UNSPECIFIED is invalid; UI defaults to Replace but must send it explicitly
  • profile ID/digest are non-secret correlation metadata, not signature verification

Verification

  • buf format --diff --exit-code
  • buf lint
  • buf breaking --against .git#branch=master

This is a dependency draft for firmware#11109 and the on-device event profile restore work in meshtastic/firmware#11110. Related issue: #1012.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d29ba44-bdbf-4baf-a8b0-5d2daa359ec6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@RCGV1

RCGV1 commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

Closing this draft: the event-only firmware path should reuse existing channel QR add/replace semantics rather than introduce a new generic channel-profile protocol. The active work is limited to event firmware isolating its own channel and LoRa files so standard firmware naturally resumes the existing profile.

@RCGV1 RCGV1 closed this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant