Skip to content

fix the typos #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

fix the typos #43

merged 1 commit into from
May 12, 2025

Conversation

howjmay
Copy link
Contributor

@howjmay howjmay commented May 7, 2025

Summary
Fix some typos

Related Issues
Links (e.g. closes #123).

Proposed Changes

Checklist

  • Tests pass locally
  • Documentation updated if needed

@CLAassistant
Copy link

CLAassistant commented May 7, 2025

CLA assistant check
All committers have signed the CLA.

@krant
Copy link
Contributor

krant commented May 7, 2025

Hi @howjmay, thanks for the contribution!
Bear in mind that src/generated/meshtastic.rs is generated from .proto files, so if you would like to fix typos there you should go to corresponding repo, otherwise your changes will be lost upon the next protobufs update. For the same reason your format changes in meshtastic.rs makes no sense either. I'd suggest to exclude src/generated/meshtastic.rs from this PR.

@howjmay
Copy link
Contributor Author

howjmay commented May 7, 2025

Hi @krant, thanks for pointing out. I have excluded meshtastic.rs from the change.
One another question. I am very interested in contributing to this project. But I didn't see many open issues. May I ask are there any features/tasks on the TODO list now?
Thanks

@lukipuki lukipuki merged commit 8be4406 into meshtastic:main May 12, 2025
3 checks passed
@lukipuki
Copy link
Collaborator

@howjmay we don't actively keep a TODO list. Right now the contributions are mostly driven by individual needs of people that want to use this crate.

I might post some ideas for beginners but I don't think we'll actively maintain such list.

@howjmay
Copy link
Contributor Author

howjmay commented May 13, 2025

Understand. Thank you

@howjmay howjmay deleted the typos branch May 13, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants