feat: update DEF CON 34 firmware to 2.8.0.8adc7c3 - #388
Conversation
Point the DEFCON edition at the newly published build at
meshtastic.github.io/event/defcon34/firmware-2.8.0.8adc7c3 (verified
present, including the firmware-2.8.0.8adc7c3.json manifest the flasher
fetches from event/{slug}/firmware-{version}).
Drop the preview-build warning from the release notes now that this is
the real event build — the notes now open the same way every other
edition's do.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe DEF CON 34 firmware metadata now points to a newer firmware version and artifact, with updated identifiers, title, and release notes that remove the preview-build disclaimer. ChangesDEF CON 34 firmware
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@public/data/event_firmware.json`:
- Line 129: Update the DEF CON 34 firmware entry’s zipUrl to a verified,
reachable ZIP artifact, or publish the archive at the existing path before
merging. Validate the URL returns a successful download response and add
link-status validation for firmware download URLs to prevent future 404 entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 4287cc0f-8c00-4ce9-acc9-4635b20f543f
📒 Files selected for processing (1)
public/data/event_firmware.json
| "version": "2.8.0.8adc7c3", | ||
| "id": "v2.8.0.8adc7c3", | ||
| "title": "Meshtastic Firmware 2.8.0.8adc7c3", | ||
| "zipUrl": "https://github.com/meshtastic/meshtastic.github.io/raw/master/event/defcon34/firmware-2.8.0.8adc7c3.zip", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Do not merge with a 404 firmware download URL.
The new zipUrl returns HTTP 404, so users cannot download the DEF CON 34 firmware. Publish the ZIP at this path or update zipUrl to the verified working artifact URL; add a link-status check to prevent recurrence.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@public/data/event_firmware.json` at line 129, Update the DEF CON 34 firmware
entry’s zipUrl to a verified, reachable ZIP artifact, or publish the archive at
the existing path before merging. Validate the URL returns a successful download
response and add link-status validation for firmware download URLs to prevent
future 404 entries.
Points the DEF CON 34 edition at the newly published build:
event/defcon34/firmware-2.8.0.8adc7c3(was2.8.0.b00d76f).version/id/title/zipUrlbumped to2.8.0.8adc7c3## Welcome to DEF CON 34! 💀exactly like every other edition's doThe
slugstaysdefcon34, so the flasher's derived pathevent/{slug}/firmware-{version}resolves to the new directory. Verified live before opening: the manifest the flasher fetches (firmware-2.8.0.8adc7c3.json) and a sample device artifact (firmware-heltec-v3-2.8.0.8adc7c3.factory.bin) both return 200 fromraw.githubusercontent.com.Companion PR keeps the API manifest and the flasher's bundled fallback copy in sync.
Note (pre-existing, not changed here): the
zipUrlconvention —event/{slug}/firmware-{version}.zip— 404s for every edition, since github.io stores these builds as directories rather than a single zip. It's carried forward as-is; worth a separate cleanup if nothing consumes it.Summary by CodeRabbit