fix(infra): use apps/web paths in Containerfile after monorepo move#1110
Merged
Conversation
The Release Web workflow builds the Docker image with the repo root as context (file: ./apps/web/infra/Containerfile), but the Containerfile's ADD/COPY still referenced ./packages/web/dist and ./packages/web/infra/default.conf. After #1097 moved the web app to apps/web, those paths no longer exist, so buildx failed with '"/packages/web/infra/default.conf": not found'. Point both at ./apps/web/. Verified with a local multi-stage docker build against the apps/web build output.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Release Web container build after the monorepo move by updating the ADD/COPY source paths inside the Nginx Containerfile to match the new apps/web location (the image build context is the repo root in the release workflow).
Changes:
- Update the static asset
ADDpath from./packages/web/dist→./apps/web/dist. - Update the Nginx config
COPYpath from./packages/web/infra/default.conf→./apps/web/infra/default.conf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Release Web workflow fails at the
Build and push imagestep:(see failed run: https://github.com/meshtastic/web/actions/runs/27570791551)
Cause
#1097 moved the web app
packages/web → apps/web. The workflow was updated accordingly (working-directory: apps/web,file: ./apps/web/infra/Containerfile,path: apps/web/dist/build.tar), but theADD/COPYpaths insideapps/web/infra/Containerfilestill pointed at./packages/web/.... Since the image is built with the repo root as context, those paths no longer resolve.Fix
Repoint the two lines to
./apps/web/distand./apps/web/infra/default.conf(both exist).Verification
Built the image locally with the repo root as context against the real
apps/webbuild output — the previously-failingADD/COPYsteps now succeed and the image exports cleanly.Note: the local
apps/webdocker:buildnpm script still uses anapps/web-relative context and is independently stale — not touched here to keep this scoped to the release blocker.