Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backends: allow LD_LIBRARY_PATH to be overwritten in test environments #14293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lzcunt
Copy link

@lzcunt lzcunt commented Feb 23, 2025

This patch makes meson not touch LD_LIBRARY_PATH in test environments if it was set or unset. This is useful for writing test cases that validate behaviour of or otherwise depend on LD_LIBRARY_PATH, e.g. for mlibc's RTLD.

I'm not sure if anything out there relies on LD_LIBRARY_PATH being prepended by meson AND manually sets LD_LIBRARY_PATH, this could affect such use cases.

This was shortly discussed on IRC.

@lzcunt lzcunt requested a review from jpakkane as a code owner February 23, 2025 12:45
@lzcunt
Copy link
Author

lzcunt commented Feb 26, 2025

Turns out this breaks a test case (which depends on the exact opposite behavior that this patch implements), and I believe implementing this feature this way would be a breaking change that might actually affect projects. Help around how this might be implemented is appreciated. I'm thinking maybe a new method on environment() that "freezes" an environment variable (so neither meson nor anything else can append, prepend, set or unset it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant